Windows icon doesn’t work

Lecricreator · December 4, 2022, 6:56pm

Hey,
I try to create a PC build, but every time I get this error:

Error - 2 icon(s) not replaced in C:\Users\scorp360\Documents\prooggrammmer\lua\Defold\projet\drop\+\v10 buyVersion\pc\buy\x86_64-win32\DR0P In Music\DR0PInMusic.exe using C:\Users\scorp360\Documents\prooggrammmer\lua\Defold\projet\drop\DR0P\bundle\win32\work2.ico

I have read many topics to solve the problem:

Même testé les .icon que vous dites fonctionnel, mais aucun ne fonctionne.

I have removed compress for windows Vista add all image for the icon, but it always doesn’t work.

I’ve test all the icon in the topic and all icon put the same error.

Have you got an idea of the problem ?

Thanks for advance.

Lecricreator

anon95708182 · December 5, 2022, 8:29am

Oh, I get the same error now with ico files I have used without problems in previous projects.

Pkeod · December 5, 2022, 8:33am

I remember reading in changelog something was changed with Windows icons since those old posts. So people who made those changes would need to comment!

Mathias_Westerdahl · December 5, 2022, 8:58am

We updated the IconExe.java in 1.3.6, in order to support larger icon sizes.

I don’t think that the actual documentation changed though
But let’s ask @britzl if he recalls some info about this.

britzl · December 5, 2022, 12:48pm

Yes @jhonny.goransson updated to support 256px icons:

I don’t recall anything other than the fact that we needed to support 256px icons.

jhonny.goransson · December 5, 2022, 1:16pm

The errors have always been there and are not really errors, but more like warnings. I think iconexe prints that line for all the icons it couldn’t replace in the exe you are trying to update. And I think we create the exe with just a few of the supported sizes but not all so if you are trying to update an exe with a size the original exe doesn’t have you will end up with that error.

Here’s the line if anyone is interested:

github.com

defold/defold/blob/d2a345312038ca8b80256c7d846dbee4ac1a3ab6/com.dynamo.cr/com.dynamo.cr.bob/src/com/dynamo/bob/bundle/IconExe.java#L79

    
      
          				}
          			} catch (RuntimeException e) {
          				//ignore so that we process the other images
          			}
          		}
          		ImageData[] data = new ImageData[images.size()];
          		data = images.toArray(data);
          
          
		int nMissing = unloadIcons(args[0], data);
          		if (nMissing != 0)
          			System.err.println("Error - " + nMissing + " icon(s) not replaced in " + args[0] + " using " + args[1]); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
          	}
          
          
	/* Implementation */
          
          
	/**
          	 * Retrieve the Desktop icons provided in the Windows executable program.
          	 * These icons are typically shown in various places of the Windows desktop.
          	 *
          	 * Note 2. The Eclipse 4.2 launcher requires an .ico file with the following 7 images (in any order).
          	 * 1. 256x256, 32 bit (RGB / Alpha Channel)

Lecricreator · December 5, 2022, 8:55pm

Ok, it’s interesting.

I restart my Window and now the icon appears.
I have the impression that as long as I don’t restart Windows, it will keep the icon it has had since startup.

I also noticed a detail:
It is possible to test if all file sizes are there in the file explorer in view.