Problems with defold-sharing

Luciatar · June 30, 2022, 10:24am

Hi i’ve been using defold-sharing on 2 of my projects. And im sure I had it working. But just tried it now and it seems to be broken.

this is my code:

	screenshot.png(function(self, img, w, h)
					
					share.image(img, " Lorem ipsum etc etc", "score.png")
					
				end)

Am I doing something wrong? any clues as to what may be the issue?

britzl · June 30, 2022, 10:40am

How? Does it crash? Do you get an error?

Luciatar · June 30, 2022, 11:04am

No it dosn’t crash, the rest of game keeps working.
I only ever got it to work in html5 in android. not sure how to check the log there.
In html5 on Pc it says:

Sharing Error: TypeError: Cannot read properties of null (reading ‘1’)

britzl · June 30, 2022, 1:19pm

Ok, I think it crashes here:

github.com

britzl/defold-sharing/blob/master/share/lib/web/lib_share.js#L59

    
      
              }
          },
          
          
ShareImage: function (data, text, name) {
              if (navigator && navigator.share) {
                  try {
                      var file_data = data ? UTF8ToString(data) : '';
                      var file_text = text ? UTF8ToString(text) : undefined;
                      var file_name = (name ? UTF8ToString(name) : 'file.png');
                      var arr = file_data.split(',');
                      var mime = arr[0].match(/:(.*?);/)[1];
                      var bstr = atob(arr[1]);
                      var n = bstr.length;
                      var u8arr = new Uint8Array(n);
                      while (n--) {
                          u8arr[n] = bstr.charCodeAt(n);
                      }
                      var file = new File([u8arr], file_name, { type: mime });
                      var shareData = {
                          files: [file],
                          title: file_name,

Can you make sure that img in the screenshot.png callback is not nil?

Luciatar · July 19, 2022, 10:19am

something like this?

				screenshot.png(function(self, img, w, h)
					pprint(img)
					if not img == nil then
						share.image(img, "Lorem ipsum etc etc", "score.png")
					else
						print("img is nil")
					end
				end)

im sorry im not sure I understand

britzl · July 19, 2022, 10:49am

Exactly. What happens if you try to check img like you do in the code you shared? Is it nil?

Luciatar · July 19, 2022, 11:00am

yeah it prints some strange characters but it does seem like it is nill.
here is an image of the console:
share_test

britzl · July 19, 2022, 11:10am

Oh, one thing I noticed in your code (which you have removed now) was this:

if not img == nil then

I don’t think it evaluates as you expect it to. The Lua operator precedence will evaluate not before ==:

https://www.lua.org/pil/3.5.html

What you want to write is this:

if not (img == nil) then

or

if img ~= nil then

Luciatar · July 19, 2022, 11:17am

woops thanks for the clarification!
fixed code to this:

                print("sharing image")
				screenshot.png(function(self, img, w, h)
					pprint(img)
					if img ~= nil then
						share.image(img, "Mira sa meva puntuacio amb es joc de l'EMT!\nFes click aqui per jugar https://emt2048.netlify.app/", "score.png")
					else
						print("img is nil")
					end
				end)

now im back to the initial error message i got before:
sharetest_fixed

britzl · July 19, 2022, 11:46am

Hmm, ok, so the image is correct. Which version of defold-sharing are you using? What do you have in game.project dependencies?

Luciatar · July 19, 2022, 11:52am

I believe i am using the last one.
project_settings

britzl · July 19, 2022, 2:39pm

Ok, could you please create a ticket in defold-sharing and include a minimal project I can use to investigate this issue?

Luciatar · July 20, 2022, 8:02am

Okay, I submitted a ticket. Hope it’s what you need!

Luciatar · August 3, 2022, 9:27am

Hi, so I saw the update to the library but I still can’t get it to work.
No I get: “Sharing Error: NotAllowedError: Permission denied”

Have you managed to get it working?

britzl · August 3, 2022, 1:28pm

Yes it works on macOS when testing in Safari. Firefox and Chrome doesn’t work (which seems to be according to spec). Perhaps it’s possible to request a sharing permission or something?

Luciatar · August 4, 2022, 6:50am

Are you sure its acording to spec? Mdn web docs share the Navigator.share example in this page works fine on chrome and firefox. No need to request permission.

britzl · August 4, 2022, 7:34am

Nope. Not on macOS in latest Chrome:

The same on Firefox. On macOS it only works on Safari.

Luciatar · August 4, 2022, 7:56am

I see… it works fine on windows and android. Seems to be a macOS issue.
I updated the minimal project and now get the permission error:

I believe this is an issue with defold-sharing as the Mdn web docs share works fine.

Luciatar · August 4, 2022, 8:02am

I just tested the min project on a collegues mac using safari and I get the same permission error. Mdn web docs share both examples work for me, including the sharing .png example. So the permission error should not be triggering since .png is an allowed file type in the spec.

britzl · August 4, 2022, 8:29am

What if you modify your sample app to share a text instead of an image? This will make it work the same way as the MDN example.