Problems with defold-sharing

Luciatar · August 4, 2022, 9:13am

Below the MDN text example there is another example that shares an image wich works fine.

britzl · August 4, 2022, 12:36pm

Ok. Well, I don’t know what the problem is then to be honest. The image sharing code is here:

britzl/defold-sharing/blob/master/share/lib/web/lib_share.js#L52-L93

    
      
          ShareImage: function (data, size, text, name) {
              if (navigator && navigator.share) {
                  try {
                      var file_data = data ? UTF8ToString(data) : '';
                      var file_text = text ? UTF8ToString(text) : undefined;
                      var file_name = (name ? UTF8ToString(name) : 'file.png');
          
          
            var mime_type = null;
                      var image_data = null;
                      if (file_data.startsWith("data:")) {
                          // https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URLs
                          var arr = file_data.split(',');
                          mime_type = arr[0].match(/:(.*?);/)[1];
          
          
                // base64 decode
                          var bstr = atob(arr[1]);
          
          
                // copy
                          var n = bstr.length;
                          image_data = new Uint8Array(n);

This file has been truncated. show original

You’re welcome to try and make changes to it to get it to work.

britzl · August 4, 2022, 12:42pm

One thing might be the fact that the code doesn’t set a mime type. That could be the reason for the permission error. We could use the file extension to look up the correct mime type.

Luciatar · August 8, 2022, 10:38am

Im having a look to see if i can figure it out… but I’m still a bit lost.
Im trying to modify the library to hardcode ->( type: “image/png”)

         var file = new File([image_data], file_name, { type: "image/png"  });

But can’t work out how to modify the library.
Should I open an issue in github?

britzl · August 8, 2022, 11:07am

You can either download the source code and put it in your own project or make a copy of it to your own user on GitHub (called a Fork): Fork a repo - GitHub Docs

Once you have a copy you make the modifications there and use the copy instead.

britzl · August 8, 2022, 4:47pm

By the way, I added the code here:

github.com

britzl/defold-sharing/blob/master/share/lib/web/lib_share.js#L58-L66

    
      
          var file_ext = file_name.split('.').pop();
          
          
const MIME_TYPES = {
              "png": "image/png",
              "jpg": "image/jpeg",
              "jpeg": "image/jpeg",
              "gif": "image/gif"
          };
          var mime_type = MIME_TYPES[file_ext];

You can give that a try and see if it helps to also provide the mime type!

Luciatar · August 9, 2022, 7:20am

Yaaay!! you fixed it! that’s fantastic, thankyou! ^^

britzl · August 9, 2022, 7:34am

Oh, it works?!

Luciatar · August 9, 2022, 7:36am

yeah all good now!