What is UpdateRSI? (Profiler abnormal values)

Dragosha · November 26, 2024, 6:59pm

In some game launches I see high values of the UpdateRSI parameter in the profiler, but I don’t really understand what they are based on. What exactly does this value mean? Searching the forum and manual did not give an answer.

upd.
Hmm. From source code it looks like it’s the render script execution time, but that doesn’t give any insight into what’s taking so long.

github.com

defold/defold/blob/4ec17be65ff55bc5f54fa8120f2ece925d870c3f/engine/render/src/render/render_script.cpp#L3477

    
      
              DM_PROFILE("DispatchRSI");
              DispatchContext context;
              context.m_Instance = instance;
              context.m_Result = RENDER_SCRIPT_RESULT_OK;
              dmMessage::Dispatch(instance->m_RenderContext->m_Socket, DispatchCallback, (void*)&context);
              return context.m_Result;
          }
          
          
RenderScriptResult UpdateRenderScriptInstance(HRenderScriptInstance instance, float dt)
          {
              DM_PROFILE("UpdateRSI");
              instance->m_CommandBuffer.SetSize(0);
          
          
    dmScript::UpdateScriptWorld(instance->m_ScriptWorld, dt);
          
          
    RenderScriptResult result = RunScript(instance, RENDER_SCRIPT_FUNCTION_UPDATE, (void*)&dt);
          
          
    if (instance->m_CommandBuffer.Size() > 0)
                  ParseCommands(instance->m_RenderContext, &instance->m_CommandBuffer.Front(), instance->m_CommandBuffer.Size());
              return result;
          }

britzl · November 26, 2024, 7:21pm

It looks like we are not measuring all parts of the UpdateRenderScriptInstance() function. In your screenshot there’s a few sub-scopes

Update 0.001
RenderScript 0.068 from https://github.com/defold/defold/blob/dev/engine/render/src/render/render_script.cpp#L3555

Then we iterate over the command buffer via ParseCommands:

github.com

defold/defold/blob/dev/engine/render/src/render/render_script.cpp#L3558

    
      
              RenderScriptResult UpdateRenderScriptInstance(HRenderScriptInstance instance, float dt)
              {
                  DM_PROFILE("UpdateRSI");
                  instance->m_CommandBuffer.SetSize(0);
          
          
        dmScript::UpdateScriptWorld(instance->m_ScriptWorld, dt);
          
          
        RenderScriptResult result = RunScript(instance, RENDER_SCRIPT_FUNCTION_UPDATE, (void*)&dt);
          
          
        if (instance->m_CommandBuffer.Size() > 0)
                      ParseCommands(instance->m_RenderContext, &instance->m_CommandBuffer.Front(), instance->m_CommandBuffer.Size());
                  return result;
              }
          
          
    void OnReloadRenderScriptInstance(HRenderScriptInstance render_script_instance)
              {
                  RunScript(render_script_instance, RENDER_SCRIPT_FUNCTION_ONRELOAD, 0x0);
              }
          }

I bet it is one of the commands that take long and we do not profile all of them.

github.com

defold/defold/blob/dev/engine/render/src/render/render_command.cpp#L58-L231

    
      
          void ParseCommands(dmRender::HRenderContext render_context, Command* commands, uint32_t command_count)
          {
              dmGraphics::HContext context = dmRender::GetGraphicsContext(render_context);
          
          
    for (uint32_t i=0; i<command_count; i++)
              {
                  Command* c = &commands[i];
                  switch (c->m_Type)
                  {
                      case COMMAND_TYPE_ENABLE_STATE:
                      {
                          dmGraphics::EnableState(context, (dmGraphics::State)c->m_Operands[0]);
                          break;
                      }
                      case COMMAND_TYPE_DISABLE_STATE:
                      {
                          dmGraphics::DisableState(context, (dmGraphics::State)c->m_Operands[0]);
                          break;
                      }
                      case COMMAND_TYPE_SET_RENDER_TARGET:

This file has been truncated. show original

Dragosha · November 27, 2024, 10:51am

Thanks for the reply. I did some more research comparing two technically identical projects, but one has a large RSI the other is regular and found out suddenly that in the first project the checkbox verify graphics calls was switched off. After switching it on the values normalised.