Replace atlast with liveupdate version

d954mas · April 10, 2024, 2:06pm

I am trying to use liveupdate to load atlas with icons.
But i get this erorr.

It is because i already use this atlas in game?

go.property("atlas_empty", resource.atlas("/assets/images/icons/skins/skins_empty.atlas"))
go.property("atlas", resource.atlas("/assets/images/icons/skins/skins.atlas"))

function init(self)
	print(self.atlas_empty)
	print(self.atlas)
	pprint(resource.get_atlas(self.atlas_empty).animations)
	pprint(resource.get_atlas(self.atlas).animations)
	print("replace skins atlas")
	resource.set_atlas(self.atlas_empty, resource.get_atlas(self.atlas))
	pprint(resource.get_atlas(self.atlas_empty).animations)
end

Logs

DEBUG:SCRIPT: [INFO 16:58:16] none: liveupdate_atlases.script:5: hash: [/assets/images/icons/skins/skins_empty.a.texturesetc]
DEBUG:SCRIPT: [INFO 16:58:16] none: liveupdate_atlases.script:6: hash: [/assets/images/icons/skins/skins.a.texturesetc]
DEBUG:SCRIPT: 
{ --[[000002B877B72140]]
  1 = { --[[000002B877B72190]]
    flip_vertical = false,
    width = 64,
    id = "unknown",
    height = 84,
    fps = 30,
    playback = 0,
    frame_start = 1,
    frame_end = 2,
    flip_horizontal = false
  }
}
DEBUG:SCRIPT: 
{ --[[000002B877B72850]]
  1 = { --[[000002B877B728A0]]
    flip_vertical = false,
    width = 61,
    id = "char_beard_man",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 1,
    frame_end = 2,
    flip_horizontal = false
  },
  2 = { --[[000002B877B72920]]
    flip_vertical = false,
    width = 61,
    id = "char_boxer",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 2,
    frame_end = 3,
    flip_horizontal = false
  },
  3 = { --[[000002B877B729A0]]
    flip_vertical = false,
    width = 61,
    id = "char_boxer_girl",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 3,
    frame_end = 4,
    flip_horizontal = false
  },
  4 = { --[[000002B877B72C60]]
    flip_vertical = false,
    width = 61,
    id = "char_cookie",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 4,
    frame_end = 5,
    flip_horizontal = false
  },
  5 = { --[[000002B877B72E90]]
    flip_vertical = false,
    width = 61,
    id = "char_cool_guy",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 5,
    frame_end = 6,
    flip_horizontal = false
  },
  6 = { --[[000002B877B72A20]]
    flip_vertical = false,
    width = 61,
    id = "char_cyborg",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 6,
    frame_end = 7,
    flip_horizontal = false
  },
  7 = { --[[000002B877B730F0]]
    flip_vertical = false,
    width = 61,
    id = "char_dark_soldier",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 7,
    frame_end = 8,
    flip_horizontal = false
  },
  8 = { --[[000002B877B734E0]]
    flip_vertical = false,
    width = 61,
    id = "char_eagle",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 8,
    frame_end = 9,
    flip_horizontal = false
  },
  9 = { --[[000002B877B73530]]
    flip_vertical = false,
    width = 61,
    id = "char_executener",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 9,
    frame_end = 10,
    flip_horizontal = false
  },
  10 = { --[[000002B877B72F10]]
    flip_vertical = false,
    width = 61,
    id = "char_general",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 10,
    frame_end = 11,
    flip_horizontal = false
  },
  11 = { --[[000002B877B73B30]]
    flip_vertical = false,
    width = 61,
    id = "char_human_1",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 11,
    frame_end = 12,
    flip_horizontal = false
  },
  12 = { --[[000002B877B73BB0]]
    flip_vertical = false,
    width = 61,
    id = "char_kori",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 12,
    frame_end = 13,
    flip_horizontal = false
  },
  13 = { --[[000002B877B73DC0]]
    flip_vertical = false,
    width = 61,
    id = "char_layer",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 13,
    frame_end = 14,
    flip_horizontal = false
  },
  14 = { --[[000002B877B73FF0]]
    flip_vertical = false,
    width = 61,
    id = "char_mecha",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 14,
    frame_end = 15,
    flip_horizontal = false
  },
  15 = { --[[000002B877B74070]]
    flip_vertical = false,
    width = 61,
    id = "char_metalmecha",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 15,
    frame_end = 16,
    flip_horizontal = false
  },
  16 = { --[[000002B877B74410]]
    flip_vertical = false,
    width = 61,
    id = "char_ninja",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 16,
    frame_end = 17,
    flip_horizontal = false
  },
  17 = { --[[000002B877B74640]]
    flip_vertical = false,
    width = 61,
    id = "char_policeman",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 17,
    frame_end = 18,
    flip_horizontal = false
  },
  18 = { --[[000002B877B746C0]]
    flip_vertical = false,
    width = 61,
    id = "...
[Output truncated]
DEBUG:SCRIPT: [INFO 16:58:16] none: liveupdate_atlases.script:9: replace skins atlas
DEBUG:SCRIPT: 
{ --[[000002B8780A9210]]
  1 = { --[[000002B8780A9260]]
    flip_vertical = false,
    width = 61,
    id = "char_beard_man",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 1,
    frame_end = 2,
    flip_horizontal = false
  },
  2 = { --[[000002B8780A92B0]]
    flip_vertical = false,
    width = 61,
    id = "char_boxer",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 2,
    frame_end = 3,
    flip_horizontal = false
  },
  3 = { --[[000002B8780A9300]]
    flip_vertical = false,
    width = 61,
    id = "char_boxer_girl",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 3,
    frame_end = 4,
    flip_horizontal = false
  },
  4 = { --[[000002B8780A9350]]
    flip_vertical = false,
    width = 61,
    id = "char_cookie",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 4,
    frame_end = 5,
    flip_horizontal = false
  },
  5 = { --[[000002B8780A93A0]]
    flip_vertical = false,
    width = 61,
    id = "char_cool_guy",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 5,
    frame_end = 6,
    flip_horizontal = false
  },
  6 = { --[[000002B8780A95D0]]
    flip_vertical = false,
    width = 61,
    id = "char_cyborg",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 6,
    frame_end = 7,
    flip_horizontal = false
  },
  7 = { --[[000002B8780A9970]]
    flip_vertical = false,
    width = 61,
    id = "char_dark_soldier",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 7,
    frame_end = 8,
    flip_horizontal = false
  },
  8 = { --[[000002B8780A99C0]]
    flip_vertical = false,
    width = 61,
    id = "char_eagle",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 8,
    frame_end = 9,
    flip_horizontal = false
  },
  9 = { --[[000002B8780A9D60]]
    flip_vertical = false,
    width = 61,
    id = "char_executener",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 9,
    frame_end = 10,
    flip_horizontal = false
  },
  10 = { --[[000002B8780A9580]]
    flip_vertical = false,
    width = 61,
    id = "char_general",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 10,
    frame_end = 11,
    flip_horizontal = false
  },
  11 = { --[[000002B8780A9DB0]]
    flip_vertical = false,
    width = 61,
    id = "char_human_1",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 11,
    frame_end = 12,
    flip_horizontal = false
  },
  12 = { --[[000002B8780AA540]]
    flip_vertical = false,
    width = 61,
    id = "char_kori",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 12,
    frame_end = 13,
    flip_horizontal = false
  },
  13 = { --[[000002B8780AA590]]
    flip_vertical = false,
    width = 61,
    id = "char_layer",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 13,
    frame_end = 14,
    flip_horizontal = false
  },
  14 = { --[[000002B8780AA7A0]]
    flip_vertical = false,
    width = 61,
    id = "char_mecha",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 14,
    frame_end = 15,
    flip_horizontal = false
  },
  15 = { --[[000002B8780AA7F0]]
    flip_vertical = false,
    width = 61,
    id = "char_metalmecha",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 15,
    frame_end = 16,
    flip_horizontal = false
  },
  16 = { --[[000002B8780AAB90]]
    flip_vertical = false,
    width = 61,
    id = "char_ninja",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 16,
    frame_end = 17,
    flip_horizontal = false
  },
  17 = { --[[000002B8780AABE0]]
    flip_vertical = false,
    width = 61,
    id = "char_policeman",
    height = 120,
    fps = 30,
    playback = 0,
    frame_start = 17,
    frame_end = 18,
    flip_horizontal = false
  },
  18 = { --[[000002B8780AAF80]]
    flip_vertical = false,
    width = 61,
    id = "...
[Output truncated]

ERROR

Assertion failed: i < m_Capacity, file D:\a\defold\defold\tmp\dynamo_home\include\dlib/opaque_handle_container.h, line 244
INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\user\AppData\Roaming\Defold/_crash
ERROR:CRASH: CALL STACK:

ERROR:CRASH:  0 0x7FF77C494660 dmCrash::GenerateCallstack D:\a\defold\defold\engine\crash\src\backtrace_win32.cpp:144
ERROR:CRASH:  1 0x7FF77C7CD810 raise /tmp/job2786423018271048004/minkernel/crts/ucrt/src/appcrt/misc/signal.cpp:547
ERROR:CRASH:  2 0x7FF77C7BDB68 abort /tmp/job2786423018271048004/minkernel/crts/ucrt/src/appcrt/startup/abort.cpp:71
ERROR:CRASH:  3 0x7FF77C7BCE4C common_assert_to_stderr<wchar_t> /tmp/job2786423018271048004/minkernel/crts/ucrt/src/appcrt/startup/assert.cpp:186
ERROR:CRASH:  4 0x7FF77C7BC964 _wassert /tmp/job2786423018271048004/minkernel/crts/ucrt/src/appcrt/startup/assert.cpp:443
ERROR:CRASH:  5 0x7FF77C44FAA0 dmOpaqueHandleContainer<unsigned __int64>::Get D:\a\defold\defold\tmp\dynamo_home\include\dlib\opaque_handle_container.h:231
ERROR:CRASH:  6 0x7FF77C45C140 dmGraphics::OpenGLGetOriginalTextureHeight D:\a\defold\defold\engine\graphics\src\opengl\graphics_opengl.cpp:3447
ERROR:CRASH:  7 0x7FF77C46F950 dmGameSystem::SetupGuiScene D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:606
ERROR:CRASH:  8 0x7FF77C4702D0 dmGameSystem::CompGuiCreate D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:781
ERROR:CRASH:  9 0x7FF77C4ED260 dmGameObject::CreateComponents D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:829
ERROR:CRASH: 10 0x7FF77C460E70 dmGameObject::AcquireResources D:\a\defold\defold\engine\gameobject\src\gameobject\res_collection.cpp:143
ERROR:CRASH: 11 0x7FF77C4617C0 dmGameObject::ResCollectionCreate D:\a\defold\defold\engine\gameobject\src\gameobject\res_collection.cpp:261
ERROR:CRASH: 12 0x7FF77C4E3780 dmResource::CreateResource D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:546
ERROR:CRASH: 13 0x7FF77C4E3C10 dmResource::PreloaderTryPruneParent D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:684
ERROR:CRASH: 14 0x7FF77C4E3C10 dmResource::PreloaderTryPruneParent D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:686
ERROR:CRASH: 15 0x7FF77C4E3C10 dmResource::PreloaderTryPruneParent D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:686
ERROR:CRASH: 16 0x7FF77C4E3C10 dmResource::PreloaderTryPruneParent D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:686
ERROR:CRASH: 17 0x7FF77C4E3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:812
ERROR:CRASH: 18 0x7FF77C4E40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760
ERROR:CRASH: 19 0x7FF77C4E3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:823
ERROR:CRASH: 20 0x7FF77C4E40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760
ERROR:CRASH: 21 0x7FF77C4E3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:823
ERROR:CRASH: 22 0x7FF77C4E40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760
ERROR:CRASH: 23 0x7FF77C4E3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:823
ERROR:CRASH: 24 0x7FF77C4E40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760
ERROR:CRASH: 25 0x7FF77C4E3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:823
ERROR:CRASH: 26 0x7FF77C4E40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760
ERROR:CRASH: 27 0x7FF77C4E1430 dmResource::UpdatePreloader D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:951
ERROR:CRASH: 28 0x7FF77C5F75F0 dmGameSystem::CompCollectionProxyUpdate D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_collection_proxy.cpp:250
ERROR:CRASH: 29 0x7FF77C4F4540 dmGameObject::Update D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2555
ERROR:CRASH: 30 0x7FF77C5792E0 dmEngine::StepFrame D:\a\defold\defold\engine\engine\src\engine.cpp:1642
ERROR:CRASH: 31 0x7FF77C574200 dmEngineUpdate D:\a\defold\defold\engine\engine\src\engine.cpp:2177
ERROR:CRASH: 32 0x7FF77C579D90 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:83
ERROR:CRASH: 33 0x7FF77C482250 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148
ERROR:CRASH: 34 0x7FF77C776714 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
ERROR:CRASH: 35 0x7FFE1DAF7330 BaseThreadInitThunk <unknown>:0
ERROR:CRASH: 36 0x7FFE1E442690 RtlUserThreadStart <unknown>:0
ERROR:CRASH:

d954mas · April 10, 2024, 2:32pm

Ok if i add timer.delay it worked)

Now i have second problem.
For some images i get strange size.

It looks like if image is rotated in atlas i get bad size(

if LIVEUPDATE.is_ready() then
	gui.set_texture(self.vh_skin.icon, HASH_SKINS)
	gui.play_flipbook(self.vh_skin.icon, self.def.icon)
	gui.set_size_mode(self.vh_skin.icon, gui.SIZE_MODE_AUTO)
else
	gui.set_texture(self.vh_skin.icon, HASH_GUI)
	gui.play_flipbook(self.vh_skin.icon, "unknown")
	gui.set_size_mode(self.vh_skin.icon, gui.SIZE_MODE_AUTO)
end

d954mas · April 10, 2024, 3:43pm

In gui you add check that image is rotated.

github.com

defold/defold/blob/04741b57446388969609d80746bef20dc824be0d/engine/gui/src/gui.cpp#L1032

    
      
             n.m_NodeType == NODE_TYPE_PARTICLEFX || n.m_TextureType != NODE_TEXTURE_TYPE_TEXTURE_SET ||
             n.m_TextureSetAnimDesc.m_TexCoords == 0x0)
          {
              return;
          }
          
          
const float* tc = GetNodeFlipbookAnimUVInternal(in);
          TextureSetAnimDesc* anim_desc = &n.m_TextureSetAnimDesc;
          
          
float w,h;
          if(tc[0] != tc[2] && tc[3] != tc[5])
          {
              // uv-rotated
              w = tc[2]-tc[0];
              h = tc[1]-tc[5];
              n.m_Properties[PROPERTY_SIZE][0] = h * (float)anim_desc->m_State.m_OriginalTextureHeight;
              n.m_Properties[PROPERTY_SIZE][1] = w * (float)anim_desc->m_State.m_OriginalTextureWidth;
          }
          else
          {
              w = tc[4]-tc[0];

I think in resource.get_atlas, you also need to add check for rotation?

github.com

defold/defold/blob/00592ce97d9ecfb559a2aba5bba8117ae0328614/engine/gamesys/src/gamesys/scripts/script_resource.cpp#L2661

    
      
          
          
{
              assert(geom.m_Vertices.m_Count % 2 == 0);
              assert(geom.m_Uvs.m_Count      % 2 == 0);
              assert(geom.m_Indices.m_Count  % 3 == 0);
          
          
    lua_pushliteral(L, "vertices");
              lua_newtable(L);
              for (int j = 0; j < geom.m_Vertices.m_Count; j += 2)
              {
                  float x = (geom.m_Vertices[j] + 0.5) * geom.m_Width;
                  float y = (0.5 - geom.m_Vertices[j+1]) * geom.m_Height;
          
          
        SET_LUA_TABLE_RAW(lua_pushnumber, j + 1, x);
                  SET_LUA_TABLE_RAW(lua_pushnumber, j + 2, y);
              }
              lua_rawset(L, -3);
          
          
    lua_pushliteral(L, "uvs");
              lua_newtable(L);
              for (int j = 0; j < geom.m_Uvs.m_Count; j += 2)

I try to fix geomtry and now i get this)
Any ideas how to fix rotation?

local atlas = resource.get_atlas(self.atlas)
		for idx,geometry in ipairs(atlas.geometries) do
			if geometry.uvs[1]	~= geometry.uvs[3] then
				local tc = geometry.vertices
				--add rotation to geometry
				local new_vertices = {
					tc[3], tc[4],
					tc[5], tc[6],
					tc[7], tc[8],   -- top-right (corresponds to UV top-right)
					tc[1], tc[2],  -- bottom-right (corresponds to UV bottom-right)
				}

				geometry.vertices = new_vertices
			end
		end

d954mas · April 10, 2024, 4:29pm

Add rotation in gui)

I have no idea how to return this rotation in atlas)

if COMMON.skins_atlas.animations[self.def.icon].need_rotate then
	gui.set_rotation(self.vh_skin.icon, vmath.vector3(0,0,90))
else
	gui.set_rotation(self.vh_skin.icon, vmath.vector3(0,0,0))
end

Chung_Xa · April 10, 2024, 5:49pm

Did you try gui.set_texture() with the atlas texture and then using gui.play_flipbook() as usual?

d954mas · April 10, 2024, 6:01pm

Yes I change texture and then play_flipbook.
And if texture region in atlas is rotated, image in node have wrong width and height

Chung_Xa · April 10, 2024, 6:09pm

So you used the texture entry returned from resource.get_atlas()? If yes it should be a bug

d954mas · April 11, 2024, 11:27am

Try to make repro cases.
I can’t reproduce this error in small repro case. But mb other errors that i can reproduce give you some ideas

github.com/defold/defold

gui crashed if change atlas in runtime

opened 11:27AM - 11 Apr 24 UTC

d954mas

bug

**Describe the bug (REQUIRED)** I am trying to replace empty atlas with exist…ed atlas. I need this to load new atlas with liveupdate. In game have empty atlas then i load new atlas in liveupdate and replace empty atlas with new atlas. I get this error in build from editor. In this case no liveupdate archive is loading. I only load liveupdate.collection parallel to game.collection ``` Assertion failed: i < m_Capacity, file D:\a\defold\defold\tmp\dynamo_home\include\dlib/opaque_handle_container.h, line 244 INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\user\AppData\Roaming\Defold/_crash ERROR:CRASH: CALL STACK: ERROR:CRASH: 0 0x7FF6ED164660 dmCrash::GenerateCallstack D:\a\defold\defold\engine\crash\src\backtrace_win32.cpp:144 ERROR:CRASH: 1 0x7FF6ED49D810 raise /tmp/job2786423018271048004/minkernel/crts/ucrt/src/appcrt/misc/signal.cpp:547 ERROR:CRASH: 2 0x7FF6ED48DB68 abort /tmp/job2786423018271048004/minkernel/crts/ucrt/src/appcrt/startup/abort.cpp:71 ERROR:CRASH: 3 0x7FF6ED48CE4C common_assert_to_stderr<wchar_t> /tmp/job2786423018271048004/minkernel/crts/ucrt/src/appcrt/startup/assert.cpp:186 ERROR:CRASH: 4 0x7FF6ED48C964 _wassert /tmp/job2786423018271048004/minkernel/crts/ucrt/src/appcrt/startup/assert.cpp:443 ERROR:CRASH: 5 0x7FF6ED11FAA0 dmOpaqueHandleContainer<unsigned __int64>::Get D:\a\defold\defold\tmp\dynamo_home\include\dlib\opaque_handle_container.h:231 ERROR:CRASH: 6 0x7FF6ED12C140 dmGraphics::OpenGLGetOriginalTextureHeight D:\a\defold\defold\engine\graphics\src\opengl\graphics_opengl.cpp:3447 ERROR:CRASH: 7 0x7FF6ED13F950 dmGameSystem::SetupGuiScene D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:606 ERROR:CRASH: 8 0x7FF6ED1402D0 dmGameSystem::CompGuiCreate D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:781 ERROR:CRASH: 9 0x7FF6ED1BD260 dmGameObject::CreateComponents D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:829 ERROR:CRASH: 10 0x7FF6ED130E70 dmGameObject::AcquireResources D:\a\defold\defold\engine\gameobject\src\gameobject\res_collection.cpp:143 ERROR:CRASH: 11 0x7FF6ED1317C0 dmGameObject::ResCollectionCreate D:\a\defold\defold\engine\gameobject\src\gameobject\res_collection.cpp:261 ERROR:CRASH: 12 0x7FF6ED1B3780 dmResource::CreateResource D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:546 ERROR:CRASH: 13 0x7FF6ED1B3C10 dmResource::PreloaderTryPruneParent D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:684 ERROR:CRASH: 14 0x7FF6ED1B3C10 dmResource::PreloaderTryPruneParent D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:686 ERROR:CRASH: 15 0x7FF6ED1B3C10 dmResource::PreloaderTryPruneParent D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:686 ERROR:CRASH: 16 0x7FF6ED1B3C10 dmResource::PreloaderTryPruneParent D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:686 ERROR:CRASH: 17 0x7FF6ED1B3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:812 ERROR:CRASH: 18 0x7FF6ED1B40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760 ERROR:CRASH: 19 0x7FF6ED1B3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:823 ERROR:CRASH: 20 0x7FF6ED1B40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760 ERROR:CRASH: 21 0x7FF6ED1B3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:823 ERROR:CRASH: 22 0x7FF6ED1B40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760 ERROR:CRASH: 23 0x7FF6ED1B3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:823 ERROR:CRASH: 24 0x7FF6ED1B40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760 ERROR:CRASH: 25 0x7FF6ED1B3DA0 dmResource::DoPreloaderUpdateOneReq D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:823 ERROR:CRASH: 26 0x7FF6ED1B40B0 dmResource::PreloaderUpdateOneItem D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:760 ERROR:CRASH: 27 0x7FF6ED1B1430 dmResource::UpdatePreloader D:\a\defold\defold\engine\resource\src\resource_preloader.cpp:951 ERROR:CRASH: 28 0x7FF6ED2C75F0 dmGameSystem::CompCollectionProxyUpdate D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_collection_proxy.cpp:250 ERROR:CRASH: 29 0x7FF6ED1C4540 dmGameObject::Update D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2555 ERROR:CRASH: 30 0x7FF6ED2492E0 dmEngine::StepFrame D:\a\defold\defold\engine\engine\src\engine.cpp:1642 ERROR:CRASH: 31 0x7FF6ED244200 dmEngineUpdate D:\a\defold\defold\engine\engine\src\engine.cpp:2177 ERROR:CRASH: 32 0x7FF6ED249D90 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:83 ERROR:CRASH: 33 0x7FF6ED152250 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148 ERROR:CRASH: 34 0x7FF6ED446714 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 ERROR:CRASH: 35 0x7FFE1DAF7330 BaseThreadInitThunk <unknown>:0 ERROR:CRASH: 36 0x7FFE1E442690 RtlUserThreadStart <unknown>:0 ERROR:CRASH: ``` ``` local COMMON = require "libs.common" go.property("atlas_empty", resource.atlas("/assets/images/icons/skins/skins_empty.atlas")) go.property("atlas", resource.atlas("/assets/images/icons/skins/skins.atlas")) function init(self) --delay fixed it. Also when i try delay 1/60 i sometimes get error but sometimes not. --timer.delay(10/ 60, false, function() COMMON.skins_atlas = { animations = {} } local atlas = resource.get_atlas(self.atlas) for idx, geometry in ipairs(atlas.geometries) do local anim = atlas.animations[idx] local data = { id = anim.id, } COMMON.skins_atlas.animations[anim.id] = data COMMON.skins_atlas.animations[hash(anim.id)] = data if geometry.uvs[1] ~= geometry.uvs[3] then data.need_rotate = true local tc = geometry.vertices --add rotation to geometry local new_vertices = { tc[3], tc[4], tc[5], tc[6], tc[7], tc[8], tc[1], tc[2], } geometry.vertices = new_vertices--]] --now rotate uv and vertices to by 90 end end resource.set_atlas(self.atlas_empty, atlas) --end) end ``` **To Reproduce (REQUIRED)** @Jhonnyg have access to my repository https://github.com/d954mas/game-blocky-fighting/commit/fe20418d3216d7bae7a62620c69db20dba62d593 I try to make small repro case but i can't reproduce this error( **Expected behavior (REQUIRED)** Engine not crashed if i change atlas **Defold version (REQUIRED):** - Version 1.7.0 **Platforms (REQUIRED):** - Platforms: Windown **Workaround (OPTIONAL):** I removed this atlas from game_scene.gui and also add timer. But i can't be sure that game not crashed for users. If they open shop_scene.gui and liveupdate completed loading in same time. **Additional context (OPTIONAL):** https://forum.defold.com/t/replace-atlast-with-liveupdate-version/76540/9

ERROR:CRASH:  6 0x7FF77C45C140 dmGraphics::OpenGLGetOriginalTextureHeight D:\a\defold\defold\engine\graphics\src\opengl\graphics_opengl.cpp:3447
ERROR:CRASH:  7 0x7FF77C46F950 dmGameSystem::SetupGuiScene D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:606
ERROR:CRASH:  8 0x7FF77C4702D0 dmGameSystem::CompGuiCreate D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:781
ERROR:CRASH:  9 0x7FF77C4ED260 dmGameObject::CreateComponents D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:829

github.com/defold/defold

Crash when resource.set_atlas if this atlas already used by sprites

opened 07:47AM - 11 Apr 24 UTC

d954mas

bug

**Describe the bug (REQUIRED)** I am trying to change atlas but game is crashed…. ```lua go.property("atlas_empty", resource.atlas("/assets/skins_empty.atlas")) go.property("atlas_empty_fixed", resource.atlas("/assets/skins_empty_fixed.atlas")) go.property("atlas", resource.atlas("/assets/skins.atlas")) function init(self) local atlas = resource.get_atlas(self.atlas) resource.set_atlas(self.atlas_empty, atlas) for idx, geometry in ipairs(atlas.geometries) do local anim = atlas.animations[idx] local data = { id = anim.id, } if geometry.uvs[1] ~= geometry.uvs[3] then data.need_rotate = true local tc = geometry.vertices --add rotation to geometry local new_vertices = { tc[3], tc[4], tc[5], tc[6], tc[7], tc[8], tc[1], tc[2], } geometry.vertices = new_vertices--]] --now rotate uv and vertices to by 90 end end resource.set_atlas(self.atlas_empty_fixed, atlas) end ``` ``` Assertion failed: i < m_Count, file D:\a\defold\defold\engine\gamesys\build\proto\gamesys/texture_set_ddf.h, line 127 INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\user\AppData\Roaming\Defold/_crash ERROR:CRASH: CALL STACK: ERROR:CRASH: 0 0x7FF75B42E470 dmCrash::GenerateCallstack D:\a\defold\defold\engine\crash\src\backtrace_win32.cpp:144 ERROR:CRASH: 1 0x7FF75B5243FC raise minkernel\crts\ucrt\src\appcrt\misc\signal.cpp:547 ERROR:CRASH: 2 0x7FF75B508374 abort minkernel\crts\ucrt\src\appcrt\startup\abort.cpp:71 ERROR:CRASH: 3 0x7FF75B4B7D58 common_assert_to_stderr<wchar_t> minkernel\crts\ucrt\src\appcrt\startup\assert.cpp:186 ERROR:CRASH: 4 0x7FF75B4B8410 _wassert minkernel\crts\ucrt\src\appcrt\startup\assert.cpp:443 ERROR:CRASH: 5 0x7FF75B15F1F0 dmGameSystem::ResolveAnimationData D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_sprite.cpp:988 ERROR:CRASH: 6 0x7FF75B161AB0 dmGameSystem::UpdateVertexAndIndexCount D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_sprite.cpp:1729 ERROR:CRASH: 7 0x7FF75B15A080 dmGameSystem::CompSpriteRender D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_sprite.cpp:1870 ERROR:CRASH: 8 0x7FF75B09FBE0 dmGameObject::Render D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2664 ERROR:CRASH: 9 0x7FF75B07ED40 dmEngine::StepFrame D:\a\defold\defold\engine\engine\src\engine.cpp:1663 ERROR:CRASH: 10 0x7FF75B07FAA0 dmEngineUpdate D:\a\defold\defold\engine\engine\src\engine.cpp:2177 ERROR:CRASH: 11 0x7FF75B07FCD0 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:83 ERROR:CRASH: 12 0x7FF75B077F40 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148 ERROR:CRASH: 13 0x7FF75B49A344 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 ERROR:CRASH: 14 0x7FFE1DAF7330 BaseThreadInitThunk <unknown>:0 ERROR:CRASH: 15 0x7FFE1E442690 RtlUserThreadStart <unknown>:0 ERROR:CRASH: ``` **To Reproduce (REQUIRED)** See repro case. I change atlases in script init function. Also i tryed to add timer.delay it not helped **Expected behavior (REQUIRED)** If i change already used atlas game not crashed **Defold version (REQUIRED):** - Version 1.7,0 **Platforms (REQUIRED):** - Platforms:Windows **Minimal repro case project (OPTIONAL):** [gui_crash.zip](https://github.com/defold/defold/files/14942980/gui_crash.zip) **Additional context (OPTIONAL):** https://forum.defold.com/t/replace-atlast-with-liveupdate-version/76540/3

github.com/defold/defold

Gui node width and height not correct after resource.set_atlas if image in atlas rotated

opened 08:14AM - 11 Apr 24 UTC

d954mas

bug

**Describe the bug (REQUIRED)** Gui node width and height not correct after res…ource.set_atlas if image in atlas rotated Look at second node. Width and height are swapped. ![2024-04-11_11-06-29](https://github.com/defold/defold/assets/2655263/8f10e4a6-5739-4314-98ec-7603c3baaa5b) I use 3 atlases. Also i try reproduce this in gui and in sprites. Sprites not worked when i change atlas https://github.com/defold/defold/issues/8783 So for now sprites use "assets/skins.atlas" ```lua go.property("atlas_empty", resource.atlas("/assets/skins_empty.atlas")) go.property("atlas_empty_fixed", resource.atlas("/assets/skins_empty_fixed.atlas")) go.property("atlas", resource.atlas("/assets/skins.atlas")) function init(self) local atlas = resource.get_atlas(self.atlas) resource.set_atlas(self.atlas_empty, atlas) for idx, geometry in ipairs(atlas.geometries) do local anim = atlas.animations[idx] local data = { id = anim.id, } if geometry.uvs[1] ~= geometry.uvs[3] then data.need_rotate = true local tc = geometry.vertices --add rotation to geometry local new_vertices = { tc[3], tc[4], tc[5], tc[6], tc[7], tc[8], tc[1], tc[2], } geometry.vertices = new_vertices --now rotate uv and vertices to by 90 end end resource.set_atlas(self.atlas_empty_fixed, atlas) timer.delay(1, false, function() factory.create("/factories#factory1",vmath.vector3(480-100,170,0)) factory.create("/factories#factory2",vmath.vector3(480,170,0)) factory.create("/factories#factory3",vmath.vector3(480+100,170,0)) end) end ``` **To Reproduce (REQUIRED)** See repro case. **Expected behavior (REQUIRED)** If i change atlas gui nodes show it correctly. **Defold version (REQUIRED):** - Version 1.7,0 **Platforms (REQUIRED):** - Platforms:Windows **Minimal repro case project (OPTIONAL):** [gui_width_height_not_correct.zip](https://github.com/defold/defold/files/14943303/gui_width_height_not_correct.zip) **Additional context (OPTIONAL):** https://forum.defold.com/t/replace-atlast-with-liveupdate-version/76540/3

github.com/defold/defold

dmGameSystem::RenderBoxNodes crashed sometimes when change atlas

opened 08:38AM - 11 Apr 24 UTC

d954mas

bug

**Describe the bug (REQUIRED)** Sometimes i get crash if try to replace atlas w…ith liveupdate content. I tryed to make small reprocase to show it. Crash happened sometimes. I use build 5-10 times and see crash ``` NFO:DLIB: Log server started on port 54123 INFO:ENGINE: Target listening with name: LAPTOP-K0DFPU0P - fe80::747e:3b65:904b:5c9a - Windows INFO:ENGINE: Engine service started on port 54124 INFO:GRAPHICS: Installed graphics device 'ADAPTER_FAMILY_OPENGL' INFO:ENGINE: Defold Engine 1.7.0 (bf4dc66) INFO:DLIB: Initialized Remotery (ws://127.0.0.1:17815/rmt) INFO:ENGINE: Loading data from: build/default INFO:ENGINE: Initialised sound device 'default' DEBUG:SCRIPT: proxy loaded:[main:/game#proxy] INFO:DLIB: SSDP: Started on address 192.168.0.103 INFO:DLIB: SSDP: Started on address 192.168.56.1 DEBUG:SCRIPT: proxy loaded:[main:/liveupdate#proxy] INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\user\AppData\Roaming\Defold/_crash ERROR:CRASH: CALL STACK: ERROR:CRASH: 0 0x7FF6A168E470 dmCrash::GenerateCallstack D:\a\defold\defold\engine\crash\src\backtrace_win32.cpp:144 ERROR:CRASH: 1 0x7FF6A1784CFC _seh_filter_exe minkernel\crts\ucrt\src\appcrt\misc\exception_filter.cpp:219 ERROR:CRASH: 2 0x7FF6A17C9954 `__scrt_common_main_seh'::`1'::filt$0 D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:304 ERROR:CRASH: 3 0x7FF6A1705F4C __C_specific_handler D:\a\_work\1\s\src\vctools\crt\vcruntime\src\eh\riscchandler.cpp:389 ERROR:CRASH: 4 0x7FFE1E492290 __chkstk <unknown>:0 ERROR:CRASH: 5 0x7FFE1E441030 RtlRaiseException <unknown>:0 ERROR:CRASH: 6 0x7FFE1E490E90 KiUserExceptionDispatcher <unknown>:0 ERROR:CRASH: 7 0x7FF6A134AC50 dmGameSystem::RenderBoxNodes D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:1443 ERROR:CRASH: 8 0x7FF6A134D810 dmGameSystem::RenderNodes D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:2016 ERROR:CRASH: 9 0x7FF6A1684050 dmGui::RenderScene D:\a\defold\defold\engine\gui\src\gui.cpp:1561 ERROR:CRASH: 10 0x7FF6A1347880 dmGameSystem::CompGuiRender D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:2296 ERROR:CRASH: 11 0x7FF6A12FFBE0 dmGameObject::Render D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2664 ERROR:CRASH: 12 0x7FF6A1368320 dmGameSystem::CompCollectionProxyRender D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_collection_proxy.cpp:336 ERROR:CRASH: 13 0x7FF6A12FFBE0 dmGameObject::Render D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2664 ERROR:CRASH: 14 0x7FF6A12DED40 dmEngine::StepFrame D:\a\defold\defold\engine\engine\src\engine.cpp:1663 ERROR:CRASH: 15 0x7FF6A12DFAA0 dmEngineUpdate D:\a\defold\defold\engine\engine\src\engine.cpp:2177 ERROR:CRASH: 16 0x7FF6A12DFCD0 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:83 ERROR:CRASH: 17 0x7FF6A12D7F40 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148 ERROR:CRASH: 18 0x7FF6A16FA344 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 ERROR:CRASH: 19 0x7FFE1DAF7330 BaseThreadInitThunk <unknown>:0 ERROR:CRASH: 20 0x7FFE1E442690 RtlUserThreadStart <unknown>:0 ERROR:CRASH: INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\user\AppData\Roaming\Defold/_crash ERROR:CRASH: CALL STACK: ERROR:CRASH: 0 0x7FF6A134AC50 dmGameSystem::RenderBoxNodes D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:1443 ERROR:CRASH: 1 0x7FF6A134D810 dmGameSystem::RenderNodes D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:2016 ERROR:CRASH: 2 0x7FF6A1684050 dmGui::RenderScene D:\a\defold\defold\engine\gui\src\gui.cpp:1561 ERROR:CRASH: 3 0x7FF6A1347880 dmGameSystem::CompGuiRender D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:2296 ERROR:CRASH: 4 0x7FF6A12FFBE0 dmGameObject::Render D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2664 ERROR:CRASH: 5 0x7FF6A1368320 dmGameSystem::CompCollectionProxyRender D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_collection_proxy.cpp:336 ERROR:CRASH: 6 0x7FF6A12FFBE0 dmGameObject::Render D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2664 ERROR:CRASH: 7 0x7FF6A12DED40 dmEngine::StepFrame D:\a\defold\defold\engine\engine\src\engine.cpp:1663 ERROR:CRASH: 8 0x7FF6A12DFAA0 dmEngineUpdate D:\a\defold\defold\engine\engine\src\engine.cpp:2177 ERROR:CRASH: 9 0x7FF6A12DFCD0 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:83 ERROR:CRASH: 10 0x7FF6A12D7F40 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148 ERROR:CRASH: 11 0x7FF6A16FA344 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 ERROR:CRASH: 12 0x7FFE1DAF7330 BaseThreadInitThunk <unknown>:0 ERROR:CRASH: 13 0x7FFE1E442690 RtlUserThreadStart <unknown>:0 ERROR:CRASH: INFO:CRASH: Successfully wrote MiniDump to file: C:\Users\user\AppData\Roaming\Defold/_crash.dmp ``` **To Reproduce (REQUIRED)** See repro case. I think something happened if i load liveupdate and game collection in parallel.(this is hypothesis) ```lua go.property("atlas", resource.atlas("/assets/skins.atlas")) function init(self) timer.delay(1, false, function() factory.create("/factories#factory1",vmath.vector3(480-100,170,0)) factory.create("/factories#factory2",vmath.vector3(480,170,0)) factory.create("/factories#factory3",vmath.vector3(480+100,170,0)) end) msg.post("/game#proxy", "async_load") msg.post("/liveupdate#proxy", "async_load") end function on_message(self, message_id, message, sender) if message_id == hash("proxy_loaded") then print("proxy loaded:" .. sender) msg.post(sender, "enable") end end ``` **Expected behavior (REQUIRED)** Engine not crashed if i change atlas **Defold version (REQUIRED):** - Version 1.7.0 **Platforms (REQUIRED):** - Platforms: Windows **Minimal repro case project (OPTIONAL):** [gui_crash_liveupdate.zip](https://github.com/defold/defold/files/14943592/gui_crash_liveupdate.zip) **Additional context (OPTIONAL):** https://forum.defold.com/t/replace-atlast-with-liveupdate-version/76540