I'd like to add to the official Defold gamepads file

Domarius · February 17, 2024, 10:14am

I’ve updated my local copy of the default.gamepads file to include the “linux” entry for my “8BitDo Pro 2” gamepad. (With the help of @Potota on Discord, thanks!)

Is there a specific process to add my newly added gamepad layout to the official Defold repository?

mchlkpng · February 17, 2024, 3:53am

Assuming that you’re saying that you updated it to include the linux entry, for now you can just provide it in a github repository or a file download somewhere for now, the defold team will consider whether they’ll add it. Thanks for your contribution!

edit: you should probably wait for a team member to respond, but there will probably be a process with adding an issue onto github? I’m not sure though because this is to add a file and not a feature request. I’ll ping @britzl to let him see.

britzl · February 17, 2024, 10:17am

Correct. We prefer to receive a Pull Request to the main gamepad file in builtins:

github.com

defold/defold/blob/dev/engine/engine/content/builtins/input/default.gamepads

driver
{
    device: "Wireless Controller"
    platform: "osx"
    dead_zone: 0.2
    map { input: GAMEPAD_LSTICK_LEFT type: GAMEPAD_TYPE_AXIS index: 0 mod { mod: GAMEPAD_MODIFIER_NEGATE } mod { mod: GAMEPAD_MODIFIER_CLAMP } }
    map { input: GAMEPAD_LSTICK_RIGHT type: GAMEPAD_TYPE_AXIS index: 0 mod { mod: GAMEPAD_MODIFIER_CLAMP } }
    map { input: GAMEPAD_LSTICK_DOWN type: GAMEPAD_TYPE_AXIS index: 1 mod { mod: GAMEPAD_MODIFIER_CLAMP } }
    map { input: GAMEPAD_LSTICK_UP type: GAMEPAD_TYPE_AXIS index: 1 mod { mod: GAMEPAD_MODIFIER_NEGATE } mod { mod: GAMEPAD_MODIFIER_CLAMP } }
    map { input: GAMEPAD_LSTICK_CLICK type: GAMEPAD_TYPE_BUTTON index: 10 }
    map { input: GAMEPAD_RSTICK_LEFT type: GAMEPAD_TYPE_AXIS index: 2 mod { mod: GAMEPAD_MODIFIER_NEGATE } mod { mod: GAMEPAD_MODIFIER_CLAMP } }
    map { input: GAMEPAD_RSTICK_RIGHT type: GAMEPAD_TYPE_AXIS index: 2 mod { mod: GAMEPAD_MODIFIER_CLAMP } }
    map { input: GAMEPAD_RSTICK_DOWN type: GAMEPAD_TYPE_AXIS index: 5 mod { mod: GAMEPAD_MODIFIER_CLAMP } }
    map { input: GAMEPAD_RSTICK_UP type: GAMEPAD_TYPE_AXIS index: 5 mod { mod: GAMEPAD_MODIFIER_NEGATE } mod { mod: GAMEPAD_MODIFIER_CLAMP } }
    map { input: GAMEPAD_RSTICK_CLICK type: GAMEPAD_TYPE_BUTTON index: 11 }
    map { input: GAMEPAD_LPAD_LEFT type: GAMEPAD_TYPE_HAT index: 0 hat_mask: 8 }
    map { input: GAMEPAD_LPAD_RIGHT type: GAMEPAD_TYPE_HAT index: 0 hat_mask: 2 }
    map { input: GAMEPAD_LPAD_DOWN type: GAMEPAD_TYPE_HAT index: 0 hat_mask: 4 }
    map { input: GAMEPAD_LPAD_UP type: GAMEPAD_TYPE_HAT index: 0 hat_mask: 1 }
    map { input: GAMEPAD_RPAD_LEFT type: GAMEPAD_TYPE_BUTTON index: 0 }

This file has been truncated. show original

If you’re not comfortable working with Git repositories and GitHub you can also share the config here and we’ll add it ourselves:

Domarius · February 17, 2024, 11:54am

Happy to do a pull request! Happy to contribute to this ever growing list of gamepad mappings that must already cover 90% of cases, it’s amazing.

Domarius · February 27, 2024, 10:50am

I’m familiar with git but I’ve never actually made a pull request and have been reading up on it.
I’m using git-gui to push a new branch called “Domarius-Gamepads-update” (my understanding is, after it’s pushed, I can create a new “pull request” for it via the web interface).

When I push to “origin”, I get a Username and then a Password popup. If I enter my git password in, I get an error which sent me to a page about entering in your access token for the password instead.

So I try again, I use my username Domarius, and when it asks for my password, I enter my access token, one that I made for accessing private repositories. Then I get this error

Pushing to https://github.com/defold/defold.git
remote: Permission to defold/defold.git denied to Domarius.
fatal: unable to access 'https://github.com/defold/defold.git/': The requested URL returned error: 403

My guess is I have to arrange for a special access token for your repository.

Mathias_Westerdahl · February 27, 2024, 11:55am

Ah, yes so you need to make a ”fork” of the Defold repository, and you do your changes there (in a branch).

Then you can create a Pull Request from your repository (the fork) to ours.

Domarius · February 28, 2024, 10:38am

Ok I made a pull request, please let me know if it’s done correctly. There were a lot of the checkboxes that weren’t relevant because I’m simply adding layouts to the gamepad file.