Extension-push platform discrepancy

AarrrBee · March 10, 2022, 11:57am

I’ve noticed a discrepancy between iOS and Android behaviour for the payload received by the listener registered with extension-push.
In the sample project, on Android, the following is printed:

DEBUG:SCRIPT: Push payload received: (activated: false)
DEBUG:SCRIPT: data = {
field2 = Other value,
field = Some value,
}

whereas on iOS it’s:

DEBUG:SCRIPT: Push payload received: (activated: false)
DEBUG:SCRIPT: payload = {“data”:{“field”:“Some value”,“field2”:“Other value”}},
id = 2,

Effectively, Android gives me payload.payload
It’s easy enough to handle, but I wonder if it would be considered a bug?

britzl · March 10, 2022, 12:43pm

It also seems like on iOS you get the JSON as a string as opposed to a Lua table?

AarrrBee · March 10, 2022, 1:33pm

Yes, but it’s not just that.

In both cases, type(payload) == “table”
On iOS, that table has a string member called “payload” which is the JSON-encoded payload. It also supplies the id.
On Android, the table is the payload, and I don’t get the id.

britzl · March 10, 2022, 2:02pm

How are you sending the remote notification? I’m a bit confused by payload and where that’s coming from. Or is this a local notification?

AarrrBee · March 10, 2022, 2:14pm

It’s a local notification triggered by the ‘Local 10s’ button in the extension-push sample which converts the received payload to a string and displays it in the GUI - device screenshots below.
iOS
iOS
Android

britzl · March 10, 2022, 5:43pm

Ah, ok, a local notification. It looks like there is an issue in the extension code where we associate the payload with the key “payload” in the NSMutableDictionary here:

github.com

defold/extension-push/blob/master/extension-push/src/push_ios.mm#L267-L271

    
      
          NSMutableDictionary* userdata = [NSMutableDictionary dictionaryWithCapacity:2];
          userdata[@"id"] = [NSNumber numberWithInt:g_Push.m_ScheduledID];
          if (top > 3) {
              const char* payload = luaL_checkstring(L, 4);
              userdata[@"payload"] = [NSString stringWithUTF8String:payload];

But later when we receive the local notification we take the whole notification and serialize it back to JSON:

github.com

defold/extension-push/blob/master/extension-push/src/push_ios.mm#L113

    
      
              }
          }
          
          
- (void)application:(UIApplication *)application didReceiveLocalNotification:(UILocalNotification *)notification {
              bool wasActivated = (application.applicationState == UIApplicationStateInactive
                  || application.applicationState == UIApplicationStateBackground);
          
          
    dmPush::Command cmd;
              cmd.m_Callback = g_Push.m_Listener;
              cmd.m_Command = dmPush::COMMAND_TYPE_LOCAL_MESSAGE_RESULT;
              cmd.m_Result = ObjCToJson(notification.userInfo);
              cmd.m_WasActivated = wasActivated;
          
          
    if (g_Push.m_Listener) {
                  dmPush::QueuePush(&g_Push.m_CommandQueue, &cmd);
              } else {
                  dmPush::QueuePush(&g_Push.m_SavedNotifications, &cmd); // No callback yet
              }
          }
          
          
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions

I believe we should grab only the payload from the userInfo dictionary, ie replace:

cmd.m_Result = ObjCToJson(notification.userInfo);

with:

cmd.m_Result = ObjCToJson(notification.userInfo[@"payload"]);

I haven’t had time to test this myself though. Perhaps you could give it a try?

AarrrBee · March 10, 2022, 6:54pm

That crashes, and unfortunately I don’t know enough Objective-C to do anything with it.
Just to mention, I am working around if for now, so it isn’t urgent.

britzl · March 11, 2022, 1:28pm

I’m going to take a look at it now anyway!

AarrrBee · March 11, 2022, 2:22pm

Thanks. Also, I haven’t tested push (remote) notifications on iOS, so it’s possible they have the same problem.

britzl · March 15, 2022, 7:20am

FYI: We released a fix yesterday.

AarrrBee · March 15, 2022, 11:30am

Thanks, I’ll take a look.