Facebook Instant Games ads not loading more than once

britzl · February 13, 2019, 11:42am

According to the best practices for ads:

Don’t hold on to too many AdInstances: Both methods getRewardedVideoAsync or getInterstitialAdAsync return an AdInstance which can be preloaded. Preloading 3 or more AdInstances without showing them will cause subsequent attempts of creating a new AdInstance to fail. This means that calls to getRewardedVideoAsync and getInterstitialAdAsync will start to fail with error code ADS_TOO_MANY_INSTANCES until showAsync is called or until the player restarts Messenger.

There could potentially be a bug in the extension code as well. This is where references to ad instances are kept and removed:

github.com/defold/extension-fbinstant

fbinstant/lib/web/library_fbinstant.js

master


      
              }
          },
          
          
          // =====================================
          // InitializeAsync
          // =====================================
          FBInstant_PlatformInitializeAsync: function(callback) {
              console.log("FBInstant inited", Module._fbinstant_inited);
              // Was FBInstant initialized externally? (ie from index.html)
              if (Module._fbinstant_inited == true) {
                  {{{ makeDynCall("vi", "callback") }}} (1);
                  return;
              }
              FBInstant.initializeAsync().then(function() {
                  {{{ makeDynCall("vi", "callback") }}} (1);
              }).catch(function(err) {
                  console.log("FBInstant_PlatformInitializeAsync - error: " + err.message);
                  {{{ makeDynCall("vi", "callback") }}} (0);
              });

This file has been truncated. show original

And this is where they are loaded and shown:

github.com/defold/extension-fbinstant

fbinstant/lib/web/library_fbinstant.js

master


      
          },
          FBInstant_PlatformGetLeaderboardEntriesAsync: function(callback, cname, count, offset) {
              var name =  UTF8ToString(cname);
              FBInstant.getLeaderboardAsync(name).then(function(leaderboard) {
                  return leaderboard.getEntriesAsync(count, offset);
              }).then(function(entries) {
                  var entriesData = [];
                  for(var i=0; i<entries.length; i++) {
                      var entry = entries[i];
                      entriesData.push({
                          rank: entry.getRank(),
                          score: entry.getScore(),
                          formatted_score: entry.getFormattedScore(),
                          timestamp: entry.getTimestamp(),
                          extra_data: entry.getExtraData(),
                          player_name: entry.getPlayer().getName(),
                          player_id: entry.getPlayer().getID(),
                          player_photo: entry.getPlayer().getPhoto(),
                      });
                  }

This file has been truncated. show original