Defold-WebSocket (DEPRECATED)

britzl · June 13, 2019, 9:26am

Let me take a look at this again and see if anything can be done.

Yes, that’s how it is supposed to work:

britzl/defold-websocket/blob/master/websocket/sync.lua#L120


    reason = err
  end
  self:sock_close()
  if self.on_close then
    self:on_close()
  end
  self.state = 'CLOSED'
  return was_clean,code,reason or ''
end


local connect = function(self,ws_url,ws_protocol,ssl_params)
  if self.state ~= 'CLOSED' then
    return nil,'wrong state',nil
  end
  local protocol,host,port,uri = tools.parse_url(ws_url)
  -- Preconnect (for SSL if needed)
  local _,err = self:sock_connect(host,port)
  if err then
    return nil,err,nil
  end
  if protocol == 'wss' then

Link · June 13, 2019, 9:47am

But then there is confusion. Through the simulator headers = ws / wss / nil.
And through html always = binary

britzl · June 13, 2019, 9:53am

Yes, I understand the confusion. This is how it works:

On desktop and mobile we have socket connections using LuaSocket built into the engine. In order to support the WebSocket protocol we need functionality to upgrade the socket connection to a WebSocket connection. This is done by lua-websocket on which defold-websocket is based. So basically all of the Lua code in the project comes from lua-websocket and it is there to support WebSocket connections on desktop and mobile.
On HTML5 however there is no such thing as a socket. You can make HTTP requests and you can create WebSockets. When you create a TCP socket connection in an HTML5 build it will automatically be upgraded to a WebSocket. This is done by Emscripten (and Websockify). And that is why you find two different code-paths throughout the client_async.lua file. And it is the Emscripten WebSocket connection that sets the Sec-Websocket-Protocol to “binary”.
- We can maybe fix this by building using some other compiler flags or build parameters but I’m not sure about this.

filazopovich · June 14, 2019, 12:05pm

Hello!
What about support of arm64-android platform for this extension? There are problem with defold-luasec dependency.

Mathias_Westerdahl · June 14, 2019, 1:06pm

This is about another extension (defold-luasec), perhaps it’s possible to enable issues on that fork, @britzl?

Link · June 14, 2019, 4:39pm

I checked my server returns in the headers “binary” too. But crash happens anyway

even has time to accept the message, but breaks off

That is, with a handshake, everything is fine! But when receiving a message = crash

britzl · June 14, 2019, 6:17pm

I’ve released a new version of luasec with openssl compiled for arm-64: https://github.com/britzl/defold-luasec/releases/tag/1.1.0

britzl · June 14, 2019, 6:18pm

Strange. @selimanac and @endel have you been able to connect from an HTML5 Defold client to a Colyseus server?

selimanac · June 14, 2019, 7:04pm

I just build tic-tac example as html5 and test it on my local environment. Seems like it is working. To be honest, I didn’t understand the problem here.

Link · June 15, 2019, 6:13pm

The Colosseum transmits binary data. That is why it works. And I pass in all my projects = string (json), like most of the developers who use web sockets.

Is it possible to somehow choose other data types? Web socket capabilities are limited in this view.

my:

Link · June 21, 2019, 11:00pm

Pleaaaaaase, add select type

fyrros · January 27, 2020, 6:53pm

I have exact same issue! Any way to fix it?

Link · January 27, 2020, 7:15pm

No

britzl · January 28, 2020, 6:42am

Remind me again. What is the problem here? What do you mean by “type” in the context of a WebSocket?

Link · January 28, 2020, 12:56pm

Websockets can take two types, but in this implementation you can send/put only binary data.

In android / ios / simulator - two types
in hmtl5 - only binary!

Really needed: STRING!

britzl · January 28, 2020, 1:03pm

Can you provide some documentation? Is this the Sec-WebSocket-Protocol header?

In my example provided with defold-websocket I passed the wrong data to ws_protocol. I took a look at the code yesterday and made a minor change to handle this properly:

github.com

britzl/defold-websocket/blob/master/examples/websocket.gui_script#L89-L95


	-- which Sec-WebSocket-Protocol to use in the header when doing the handshake/upgrade
	-- for now we can only influence the choice of protocol in non-html5 builds
	-- in html5 builds it seems like the Sec-WebSocket-Protocol will always be "binary"
	local ws_protocol = "binary"


	log("Connecting to " .. url)
	self.ws:connect(url, ws_protocol, sslparams)

With this change all but the HTML5 platform allows you to define whatever value to Sec-WebSocket-Protocol in the second argument to self.ws:connect(url, [ws_protocol], [sslparams]).

In HTML5 builds the whole websocket setup is done by Emscripten in which case the Sec-WebSocket-Protocol is always binary. I have an idea to not use Emscripten and sockets and instead immediately use JavaScript to create the websocket.

The thing I do not understand still is why? I’m thinking that with the type set to binary you would be able to pass any kind of data. Strings are after all bytes right?

Link · January 28, 2020, 1:10pm

I thought so too, but it’s not. Socket breaks

Link · January 28, 2020, 1:12pm

It’s cool idea!
I worked with sockets on corona sdk in html including. It was done on pure JS

britzl · January 28, 2020, 1:13pm

Is there a chance for me to play around and try to connect against a server where there’s a crash when sending and receiving data?

Link · January 28, 2020, 2:03pm

Made for the test. Send any text and it returns in a second

wss://lost.webday.ru/britzl_test99