Defold 1.2.183 BETA

britzl · May 29, 2021, 9:42am

Thanks. BUTTON_MODE (key code 110) is currently not mapped to anything. The translations can be seen here:

defold/defold/blob/dev/engine/glfw/lib/android/android_joystick.c#L123-L148

    
      
          static int glfwAndroidKeycodeToJoystickButton(int keyCode)
          {
              switch(keyCode)
              {
                  case AKEYCODE_BUTTON_A:         return 0;
                  case AKEYCODE_BUTTON_B:         return 1;
                  case AKEYCODE_BUTTON_C:         return 2;
                  case AKEYCODE_BUTTON_X:         return 3;
                  case AKEYCODE_BUTTON_L1:        return 4;
                  case AKEYCODE_BUTTON_R1:        return 5;
                  case AKEYCODE_BUTTON_Y:         return 6;
                  case AKEYCODE_BUTTON_Z:         return 7;
                  case AKEYCODE_BUTTON_L2:        return 8;
                  case AKEYCODE_BUTTON_R2:        return 9;
                  case AKEYCODE_DPAD_CENTER:      return 10;
                  case AKEYCODE_DPAD_DOWN:        return 11;
                  case AKEYCODE_DPAD_LEFT:        return 12;
                  case AKEYCODE_DPAD_RIGHT:       return 13;
                  case AKEYCODE_DPAD_UP:          return 14;
                  case AKEYCODE_BUTTON_START:     return 15;

This file has been truncated. show original

What we need to do for buttons is to provide a mapping from BUTTON_MODE to the next free button index.

And AXIS mappings:

github.com

defold/defold/blob/dev/engine/glfw/lib/android/android_joystick.c#L106-L116

    
      
          static void glfwAndroidUpdateAxis(const AInputEvent* event)
          {
              const int32_t joystickIndex = glfwAndroidFindJoystick(AInputEvent_getDeviceId(event));
              if (joystickIndex >= 0)
              {
                  glfwAndroidUpdateAxisValue(joystickIndex, event, AMOTION_EVENT_AXIS_X);
                  glfwAndroidUpdateAxisValue(joystickIndex, event, AMOTION_EVENT_AXIS_Y);
                  glfwAndroidUpdateAxisValue(joystickIndex, event, AMOTION_EVENT_AXIS_Z);
                  glfwAndroidUpdateAxisValue(joystickIndex, event, AMOTION_EVENT_AXIS_RZ);
              }
          }

What we need here is to add two new mappings from AXIS_GAS and AXIS_BREAK to the next two free axis indices.

AGulev · May 29, 2021, 10:02am

I think it would be better to use AMOTION_EVENT_AXIS_LTRIGGER and AMOTION_EVENT_AXIS_RTRIGGER. It has the same values but feels a bit more suitable than BREAK and GAS (which are for a steering wheel with pedals, I think)

britzl · May 29, 2021, 1:56pm

Ah yes indeed. I thought we already had axis bindings for those!

AGulev · May 30, 2021, 3:09pm

I’ll prepare PR