Can anyone explain what is wrong with this function [SOLVED]

Questions
8

Will do. Thanks