AdMob Extension - open source now

Crypto · July 16, 2019, 7:14am

Recently, I noticed that GitHub is getting slower at providing the master.zip file of the repo. Sometimes it takes up to two minutes to open a project. (I don’t exclude that it might be a CDN problem related to my region).

Would it be possible to create a release on GitHub so we can reference that specific zip file (which is usually generated faster) in the game.project file?

More than that, it would allow to easily use a specific version of the extension in the future

sergey.lerg · July 16, 2019, 8:55am

Will do that once I resolve one outstanding issue!

AGulev · July 17, 2019, 8:09am

I added a new argument for pompom script --exclude, and now it possible to exclude libraries that already added in Defold or in some other extension automatically (example).
Defold dependencies in exceptions.json file that based on this list https://www.defold.com/manuals/extensions-details/#_android

For now this update available in separate brunch, we will merge it soon:
https://github.com/britzl/pompom/tree/new_ne_pompom

AGulev · August 19, 2019, 12:48pm

Solved in Defold 1.2.160 has been released

sergey.lerg · August 20, 2019, 5:32pm

The extension has been updated for Defold 1.2.160 and now you need to specify additional dependency extension:

https://github.com/defold/extension-firebase-core/archive/master.zip

sergey.lerg · September 16, 2019, 10:54am

With the released Defold 1.2.162, please add now extension-gps to the dependencies.

https://github.com/defold/extension-gps/archive/master.zip

Crypto · September 18, 2019, 5:06pm

Recently, I noticed that GitHub is getting slower at providing the master.zip file of the repo. Sometimes it takes up to two minutes to open a project. (I don’t exclude that it might be a CDN problem related to my region).

Would it be possible to create a release on GitHub so we can reference that specific zip file (which is usually generated faster) in the game.project file?

Any update on this? Unfortunately GitHub is still pretty slow to generate the master.zip file runtime (up to 5 minutes sometimes).

britzl · September 19, 2019, 5:33am

That can’t be right. It must be the download that is slow. On a decent connection it takes just a few seconds. From where and using what kind of connection does it take 5 minutes?

britzl · September 19, 2019, 5:36am

Oh, I just saw that you asked specifically for a release. You could fork the repo and make your own release.

sergey.lerg · September 19, 2019, 9:01am

If you only worry about download speed just download the extension manually and unpack it into your project. This way it won’t be downloading at startup at all.

Pkeod · September 19, 2019, 9:15am

I think the problem is that github re-generates/doesn’t cache the master.zip but keeps static release zips? So it adds extra wait time. This would be worth testing to see if there is actually a difference.

sergey.lerg · September 19, 2019, 9:31am

That would be a very stupid thing not to do… Personally for me there is no wait time before the download starts.

sergey.lerg · October 21, 2019, 10:08am

EXTENSION UPDATE

Added support for iOS 13. All apps for iOS must be updated.
Fixes the issue with fullscreen ads not being shown.

Google now requires to put app id into Info.plist file for iOS. See docs to add a section in game.project file.

sergey.lerg · November 11, 2019, 2:52pm

EXTENSION UPDATE

Defold has moved to a new dependency system for android extensions and this update addresses that.
Unfortunately initial Defold dependencies break the extension, so as a temporary measure I’ve made a fixed version of gps-ads-17.2.1.zip dependency.

Steps to migrate your projects:

Replace old dependencies with the new ones.
Add android_app_id value to the game.project file.
Remove app_id param from the call to admob.init().

Dragosha · November 12, 2019, 10:23am

Works correct with FB Extension v. 2.3.1

gonzalo.romero · November 16, 2019, 6:52pm

What steps should I take to achieve this?

sergey.lerg · November 16, 2019, 7:35pm

Open the game.project file with some text editor like Sublime, Visual Code or Atom and add those lines:

[admob]
ios_app_id = ca-app-pub-***~***
android_app_id = ca-app-pub-***~***

Make sure there is only one [admob] section in the file.

gonzalo.romero · November 16, 2019, 8:26pm

Thank you. My game is working again!

lrx · November 19, 2019, 12:53pm

Hi @sergey.lerg,

I’m getting an error while building (CTRL+B) the project.

I’ve updated dependencies (and fetched libs)

and also added app-id in game.project

Log says:

2019-11-19 13:24:16.387 158696 [JavaFX Application Thread] WARN  editor.app-view - {:line 804}
clojure.lang.ExceptionInfo: Failed to build engine, status 500: Internal Server Error
	at editor.engine.build_errors$build_error.invokeStatic(build_errors.clj:451)
	at editor.engine.native_extensions$build_engine_archive.invokeStatic(native_extensions.clj:245)
	at editor.engine.native_extensions$get_engine_archive.invokeStatic(native_extensions.clj:289)
	at editor.engine$get_engine.invokeStatic(engine.clj:185)
	at editor.app_view$async_build_BANG_$fn__45688$fn__45694.invoke(app_view.clj:754)
	at editor.app_view$async_build_BANG_$fn__45688.invoke(app_view.clj:752)
	at clojure.core$binding_conveyor_fn$fn__5739.invoke(core.clj:2030)
	at clojure.lang.AFn.call(AFn.java:18)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

I’ve double checked all, I can’t find what is wrong

sergey.lerg · November 19, 2019, 1:50pm

Have you tried deleting the .internal directory?