Failed to parse Manifest data

Mathias_Westerdahl · October 19, 2021, 12:28pm

I don’t think it’s the liveupdate update that is to blame here.
If you check your logcat, you’ll find “Cleaning up …” output from the engine when cleaning the old live update files. And should also only remove specific files (I.e. not all files or any folders)

Have you checked in Android Studio, if the file is still there?

Lex · October 19, 2021, 12:44pm

Interesting, i don’t see any Cleaning up logs.

I have this:

INFO:LIVEUPDATE: Found /data/user/0/com.mygame/files/liveupdate.ref
INFO:LIVEUPDATE: Found zip archive reference to /data/user/0/com.mygame/files/archive.zip
ERROR:RESOURCE: Failed to parse Manifest data (2)
ERROR:LIVEUPDATE: Could not load manifest: -2

I used to have this error message and crash, now I have this error, it doesn’t crash but my files are erased.
Trying to understand what’s going on.

Mathias_Westerdahl · October 19, 2021, 12:54pm

To be clear, the file itself is erased?
How did you verify this? Using Android Studio?
What was the actual filename?

EDIT:
How did you update the app?
Did you uninstall the previous app?

Lex · October 19, 2021, 1:19pm

I updated the app using
adb install -r path/to/app.apk

I didn’t uninstall the previous app.

I have the following logs at 2nd app startup (after update):

INFO:ENGINE: Loading data from: dmanif:game.dmanifest
INFO:LIVEUPDATE: Found /data/user/0/com.mygame/files/liveupdate.ref
INFO:LIVEUPDATE: Found zip archive reference to /data/user/0/commygame/files/archive.zip
ERROR:RESOURCE: Failed to parse Manifest data (2)
ERROR:LIVEUPDATE: Could not load manifest: -2

And to be precise, it appears the files haven’t been erased, but they became empty juding by my Defsave logs:

1st install, I see the log DefSave: Loaded file my_file is empty
2d install (update), I don’t see this log anymore. Meaning there is a file, but it’s content is empty.

Also, I don’t see any “Cleaning up” logs.

Lex · October 19, 2021, 1:30pm

I see that in your patch, you updated the liveupdate_archive.cpp

github.com

defold/defold/blob/a25ba88c45720578925bac70c5cc3603339ac569/engine/liveupdate/src/liveupdate_archive.cpp

// Copyright 2020 The Defold Foundation
// Licensed under the Defold License version 1.0 (the "License"); you may not use
// this file except in compliance with the License.
//
// You may obtain a copy of the License, together with FAQs at
// https://www.defold.com/license
//
// Unless required by applicable law or agreed to in writing, software distributed
// under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
// CONDITIONS OF ANY KIND, either express or implied. See the License for the
// specific language governing permissions and limitations under the License.

#include "liveupdate.h"
#include "liveupdate_private.h"
#include <resource/resource.h>
#include <resource/resource_archive.h>

#include <dlib/path.h>
#include <dlib/log.h>
#include <dlib/sys.h>

This file has been truncated. show original

But you haven’t touched the liveupdate_zip_archive.cpp

github.com

defold/defold/blob/b336927dd13c65abdf43f710072a8d632ade32b0/engine/liveupdate/src/liveupdate_zip_archive.cpp

// Copyright 2020 The Defold Foundation
// Licensed under the Defold License version 1.0 (the "License"); you may not use
// this file except in compliance with the License.
//
// You may obtain a copy of the License, together with FAQs at
// https://www.defold.com/license
//
// Unless required by applicable law or agreed to in writing, software distributed
// under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
// CONDITIONS OF ANY KIND, either express or implied. See the License for the
// specific language governing permissions and limitations under the License.

#include <sys/stat.h>

#include "liveupdate.h"
#include "liveupdate_private.h"
#include <resource/resource.h>
#include <resource/resource_archive.h>

#include <dlib/dstrings.h>

This file has been truncated. show original

I believe in my case, I’m using the liveupdate_zip_archive.cpp because the LiveUpdate I download is a zip file.

Mathias_Westerdahl · October 19, 2021, 1:35pm

I didn’t uninstall the previous app.

Ok, that’s good, then the files shouldn’t be removed by the installation process.

Also, I don’t see any “Cleaning up” logs.

I’m not sure why the “Cleaning up” isn’t there, but that shouldn’t be a blocker.

Meaning there is a file, but it’s content is empty.

You could perhaps try to load it manually and print out the contents?

I see that in your patch, you updated the liveupdate_archive.cpp

But you haven’t touched the liveupdate_zip_archive.cpp

Correct, it was the old archive files that produced the app exit.

Mathias_Westerdahl · October 19, 2021, 1:43pm

It seems like there’s a lot of fallbacks in defsavethat might account for storing the empty file?

github.com

subsoap/defsave/blob/master/defsave/defsave.lua#L136-L155

    
      
          	if next(loaded_file) == nil then
          		if M.verbose then print("DefSave: Loaded file '" .. file .. "' is empty") end
          		empty = true
          	end
          
          
	if M.use_default_data and empty then
          		if (M.reset_to_default(file)) then
          			return true
          		else
          			return false
          		end
          
          
	elseif empty then
          		print("DefSave: The " .. file .. " is loaded but it was empty")
          		M.loaded[file] = {}
          		M.loaded[file].changed = true
          		M.changed = true
          		M.loaded[file].data = {}
          		return true
          	end

Lex · October 19, 2021, 1:52pm

What I mean is that you updated the code in LULoadManifest_Regular ,
but when upgrading, we’re not calling LULoadManifest_Regular , we’re calling LULoadManifest_Zip

github.com

defold/defold/blob/7d417dd53770f424cc2fb3aeac5f3fc984335b85/engine/liveupdate/src/liveupdate.cpp#L506-L518

    
      
          if (g_LiveUpdate.m_ArchiveType == 1)
          {
              result = LULoadManifest_Zip(archive_name, app_path, app_support_path, base_manifest, out);
              if (dmResourceArchive::RESULT_OK != result)
              {
                  LUCleanup_Zip(archive_name, app_path, app_support_path);
                  g_LiveUpdate.m_ArchiveType = 0;
              }
              else
              {
                  LUCleanup_Regular(archive_name, app_path, app_support_path);
              }
          }

(because we have a .ref archive: https://github.com/defold/defold/blob/7d417dd53770f424cc2fb3aeac5f3fc984335b85/engine/liveupdate/src/liveupdate.cpp#L95)

If I’m not mistaken you made the changes in a part that is not encountered when running the app after an update.

Mathias_Westerdahl · October 19, 2021, 2:09pm

In the scenario we had, that was the use case that produced the repro case.
Before you started using the .zip archive, you used to download files one by one, right?
And if those files were left behind, and the engine tried to load them, the game would exit.

When the game starts, it 1) tries to load the liveupdate .zip file. If it fails, it 2) tries to load the “regular” liveupdate manifest. If that fails it 3) will (after the latest fix) proceed to load the manifest from the bundled game.

Before this fix, your game would shut down, right?
With the latest fix you can get to case 3 without the game shutting down.

Lex · October 19, 2021, 2:19pm

I’m confused, what do you mean? You mean in the past, some months ago?

In my current situation, in v1 we download a zip archive that contains all resources, we don’t download file by file.

Mathias_Westerdahl · October 19, 2021, 2:23pm

Yes. If those files were still there, they would fail the startup process.

Load .zip → fail
Load .dmanifest (regular) → fail
App exit

That is what I fixed (since that was the scenario we didn’t handle.
We already had the check for the .zip archive. We didn’t have the check for the regular live update files.

I mean, you reported that the app exited.
Does it still exit?

Lex · October 19, 2021, 3:32pm

You’re right, sorry I got confused!