Defold 1.5.0 BETA

d954mas · August 5, 2023, 4:17pm

@jhonny.goransson
I try #7800
It worked but i have crash when close game.

Crash when close game if use transfer_ownership for buffer

opened 04:14PM - 05 Aug 23 UTC

bug

**Describe the bug (REQUIRED)** Pull request #7800 Fixes #7587 1)I create bu…ffer in c++ 2)Then i set buffer to mesh ``` ... updateGoBuffer(L, goChunk, buffer); // destroy buffer. Do not need destroy i transfer_ownership // dmBuffer::Destroy(buffer); ... static void updateGoBuffer(lua_State *L, GoChunk &item, dmBuffer::HBuffer buffer) { lua_getglobal(L, "native_update_chunk_buffer"); if (!lua_isfunction(L, -1)) { luaL_error(L, "no native_update_chunk_buffer function"); } dmScript::PushURL(L, item.meshUrl); dmScript::LuaHBuffer luabuf(buffer, dmScript::OWNER_C); dmScript::PushBuffer(L, luabuf); lua_call(L, 2, 0); } //in lua function native_update_chunk_buffer(mesh_url, buffer) resource.set_buffer(go.get(mesh_url, "vertices"), buffer, { transfer_ownership = true }) end ``` 3)When i close game window engine is crashed ``` Assertion failed: resource_hash, file ..\src\resource.cpp, line 1240 INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\user\AppData\Roaming\Defold/_crash ERROR:CRASH: CALL STACK: ERROR:CRASH: 0 0x7FF6D267EC80 dmCrash::GenerateCallstack D:\a\defold\defold\engine\crash\src\backtrace_win32.cpp:144 ERROR:CRASH: 1 0x7FF6D29C2AA0 raise /tmp/job8302161979723754798/minkernel/crts/ucrt/src/appcrt/misc/signal.cpp:547 ERROR:CRASH: 2 0x7FF6D29B5BF4 abort /tmp/job8302161979723754798/minkernel/crts/ucrt/src/appcrt/startup/abort.cpp:71 ERROR:CRASH: 3 0x7FF6D29B4DBC common_assert_to_stderr<wchar_t> /tmp/job8302161979723754798/minkernel/crts/ucrt/src/appcrt/startup/assert.cpp:186 ERROR:CRASH: 4 0x7FF6D29B48E0 _wassert /tmp/job8302161979723754798/minkernel/crts/ucrt/src/appcrt/startup/assert.cpp:443 ERROR:CRASH: 5 0x7FF6D26B8920 dmResource::Release D:\a\defold\defold\engine\resource\src\resource.cpp:1242 ERROR:CRASH: 6 0x7FF6D2663CC0 dmGameSystem::CompMeshDestroy D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_mesh.cpp:422 ERROR:CRASH: 7 0x7FF6D26CD2E0 dmGameObject::DestroyComponents D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:898 ERROR:CRASH: 8 0x7FF6D26CBBC0 dmGameObject::DoDeleteInstance D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:1941 ERROR:CRASH: 9 0x7FF6D26CAA40 dmGameObject::DeleteCollection D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:525 ERROR:CRASH: 10 0x7FF6D26C69A0 dmGameObject::PostUpdate D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2812 ERROR:CRASH: 11 0x7FF6D27470B0 dmEngine::Delete D:\a\defold\defold\engine\engine\src\engine.cpp:287 ERROR:CRASH: 12 0x7FF6D274BD80 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:92 ERROR:CRASH: 13 0x7FF6D266CA70 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148 ERROR:CRASH: 14 0x7FF6D2975B94 __scrt_common_main_seh d:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 ERROR:CRASH: 15 0x7FFF72AC7600 BaseThreadInitThunk <unknown>:0 ERROR:CRASH: 16 0x7FFF72E82690 RtlUserThreadStart <unknown>:0 ERROR:CRASH: ``` No sure is it important, i use resource.create_buffer. ``` local M = {} M.idx = 0 ---@type BufferResourceData[] M.free_buffers = {} ---@type BufferResourceData[] M.all_buffers = {} local function create_default_native_buffer() return buffer.create(1, { { name = hash("data1"), type = buffer.VALUE_TYPE_UINT16, count = 1 }, { name = hash("data2"), type = buffer.VALUE_TYPE_UINT16, count = 1 }, { name = hash("data3"), type = buffer.VALUE_TYPE_UINT16, count = 1 }, }) end function M.init() M.buffer = create_default_native_buffer() for i = 1, 32 do table.insert(M.free_buffers, M.create_new_buffer(M.buffer)) end end function M.get() local buffer = table.remove(M.free_buffers) if not buffer then buffer = M.create_new_buffer() end buffer.free = false return buffer end function M.free(buffer_data) assert(buffer_data) assert(type(buffer_data.buffer), "userdata") assert(not buffer_data.free) buffer_data.free = true resource.set_buffer(buffer_data.buffer, create_default_native_buffer()) table.insert(M.free_buffers, buffer_data) end function M.create_new_buffer() M.idx = M.idx + 1 local name = "/runtime_buffer_" .. M.idx .. ".bufferc" local new_buffer = resource.create_buffer(name, { buffer = M.buffer }) ---@class BufferResourceData local buffer_resource = {} buffer_resource.name = name buffer_resource.buffer = new_buffer buffer_resource.free = true table.insert(M.all_buffers, buffer_resource) return buffer_resource end return M ``` **To Reproduce (REQUIRED)** Steps to reproduce the behavior: I can reproduce in my project. Not sure how to make small repro case. If you can't reproduce write me in pm, i can add you to project. **Expected behavior (REQUIRED)** No crash when close game **Defold version (REQUIRED):** - Version Defold 1.5.0 BETA **Platforms (REQUIRED):** - Platforms: Windows